Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add tab gate to disable focus trap #399

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

stephen-pearce
Copy link

@stephen-pearce stephen-pearce commented Oct 8, 2024

Description

Add tab gate triggered by ESC key and disabled by refocusing the editor or container

Screen.Recording.2024-10-08.at.13.28.04.mov

Fixes #390

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run all builds, tests, and linting and all checks pass
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link

changeset-bot bot commented Oct 8, 2024

🦋 Changeset detected

Latest commit: cb98b51

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-live Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-live-docs-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 5:15pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LiveEditor Keyboard accessibility; No key present to take focus to previous or next interactive element
2 participants